feat: Introduce table resize plan for scaling. #14235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
force-pushed
the
peng/new-schedule
branch
7 times, most recently
from
b31a26f to
33dbda5
Compare
Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/new-schedule
branch
from
33dbda5 to
670c33b
Compare
yezizp2012
approved these changes
Dec 28, 2023
BugenZhao
reviewed
Jan 2, 2024
Comment on lines
+475
to
+476
| FixedParallelism fixed = 1; | ||
| AutoParallelism auto = 2; |
There was a problem hiding this comment.
Would you mind adding some comments to describe them? For example, the respective behavior when auto scaling is on/off.
Comment on lines
+2584
to
+2587
| // We redistribute parallel units (which will be ensembles in the future) through a simple consistent hashing ring. | ||
| // Note that we have added some simple logic here to ensure the consistency of the ratio between each slot, | ||
| // especially when equal division is needed. | ||
| pub fn schedule_units_for_slots( |
There was a problem hiding this comment.
What about extracting this utility into separate files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
first part of #13954
Checklist
./risedev check(or alias,./risedev c)